Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for devServer.allowedHosts #1294

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Add documentation for devServer.allowedHosts #1294

merged 1 commit into from
Jun 15, 2017

Conversation

orteth01
Copy link
Contributor

related webpack-dev-server PR: webpack/webpack-dev-server#899

@orteth01
Copy link
Contributor Author

cc @shellscape

@shellscape
Copy link
Contributor

LGTM 👍

skipjack
skipjack approved these changes Jun 15, 2017
View reviewed changes
Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @orteth01!

@skipjack skipjack merged commit 603dd5c into webpack:master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellscape shellscape shellscape approved these changes

@skipjack skipjack skipjack approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orteth01 @shellscape @skipjack